search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

🐛 Add virtualcluster tests to CI #289

Closed m-messiah closed 2 years ago

m-messiah commented 2 years ago

What this PR does / why we need it:

virtual cluster tests were disabled in https://github.com/kubernetes-sigs/cluster-api-provider-nested/pull/267 and we had no CI tests since that. The PR enables them back.

The envtest is failing to start when --race flag is set, so I removed it.

Also, SHA1 is proved to be weak and golang tls prevented these certificate from being used https://github.com/golang/go/issues/41682. The PR regenerates test certificates with sha256

Also fix ginkgo warning:

You are passing a Done channel to a test node to test asynchronous behavior. This is deprecated in Ginkgo V2. Your test will run synchronously and the timeout will be ignored. Learn more at: https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md#removed-async-testing

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, m-messiah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment