search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

NestedControlPlane & NestedCluster Proposal #29

Closed christopherhein closed 3 years ago

christopherhein commented 3 years ago

Adding new proposal fromm hackmd with regards to how the NCP and NC types are made. This probably still needs a bit of work related to diagrams of interactions but for the most part these types aren't doing the actual orchestration of the control plane.

Closes #7

Signed-off-by: Chris Hein me@chrishein.com

christopherhein commented 3 years ago

/cc @Fei-Guo @charleszheng44

christopherhein commented 3 years ago

Per #30 Sounds like I need to add some functions in here about how we generate Certs if they aren't supplied.

kfox1111 commented 3 years ago

Using cert-manager please? cluster-api already depends on it.

christopherhein commented 3 years ago

Yeah, @kfox1111 I this is an option, similar to how the kubeadm bootstrap provider will create certs for you if you don't have them already created and stored in secrets. Regarding the cert-manager integration, do you think it should default to creating Certificate resources from the NestedControlPlane controller?

kfox1111 commented 3 years ago

Yeah. I think that would work well.

christopherhein commented 3 years ago

More discussion about this doc happened on today's CAPN call - recording in the notes as well as a quick summary in writing - https://docs.google.com/document/d/10aTeq2lhXW_3aFQAd_MdGjY8PtZPslKhZCCcXxFp3_Q/edit#

christopherhein commented 3 years ago

/cc @charleszheng44 @Fei-Guo @weiling61

k8s-ci-robot commented 3 years ago

@christopherhein: GitHub didn't allow me to request PR reviews from the following users: weiling61.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-nested/pull/29#issuecomment-777168208): >/cc @charleszheng44 @Fei-Guo @weiling61 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
christopherhein commented 3 years ago

Should we update "creating-controll-plane-components" proposal? since the doc still mentions that the CA will be created by each component controller.

I think so, but lets make sure we're all in agreement and I can do a follow-up PR with this change.

k8s-ci-robot commented 3 years ago

@miamipanther: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-nested/pull/29#pullrequestreview-600986380): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, miamipanther, vincepri, weiling61

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/master/OWNERS)~~ [christopherhein,vincepri] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
charleszheng44 commented 3 years ago

/lgtm