search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

Implement the NestedEtcd controller #30

Closed charleszheng44 closed 3 years ago

charleszheng44 commented 3 years ago

This PR implements the NestedEtcd controller.

charleszheng44 commented 3 years ago

This looks really good so far, nice work @charleszheng44. Do you want to talk about what you've run into today on the CAPN call?

Yes. We can talk about this PR in today's meeting.

christopherhein commented 3 years ago

We also probably want tests for this.

charleszheng44 commented 3 years ago

We also probably want tests for this.

test cases added

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charleszheng44, christopherhein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/master/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment