search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

🌱 Remove excess NodeInfo.OperatingSystem assign #300

Closed m-messiah closed 2 years ago

m-messiah commented 2 years ago

What this PR does / why we need it: The PR removes confusing excess n.Status.NodeInfo.OperatingSystem assign to Linux, which is not used anywhere and is rewritten in a couple of lines later https://github.com/m-messiah/cluster-api-provider-nested/blob/02b288a700d6ef6fd1776f4d63e3e4a7e0ca317c/virtualcluster/pkg/syncer/vnode/vnode.go#L100

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, m-messiah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment