search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

🌱 Add etcd.namespace to the etcd certificate #302

Closed m-messiah closed 2 years ago

m-messiah commented 2 years ago

What this PR does / why we need it: Currently, etcd certificate is valid for etcd-0.etcd, etcd-1.etcd, etcd-2.etcd, etcd names only. That prevents us to connect to etcd from controllers to do health checks, upgrade maintenance or backups without using InsecureSkipVerify. The PR adds virtualcluster namespace to every etcd domain, so they would be accessible

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, m-messiah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment