search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

🐛 InitContainer support for kube-root-ca.crt ConfigMaps #328

Closed christopherhein closed 1 year ago

christopherhein commented 1 year ago

What this PR does / why we need it:

After https://github.com/kubernetes-sigs/cluster-api-provider-nested/pull/326#discussion_r1017366793 was merged @wondywang noticed I missed InitContainers, this adds that capability as well.

Signed-off-by: Chris Hein christopher_hein@apple.com

Fei-Guo commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, Fei-Guo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [Fei-Guo,christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment