search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

🌱 volume.Projected support for kube-root-ca.crt ConfigMaps #334

Closed wondywang closed 1 year ago

wondywang commented 1 year ago

What this PR does / why we need it : In this PR I would like to make volume.Projected support for kube-root-ca.crt ConfigMaps. And meanwhile renew the Checker to check the TenantRootCACertConfigMapName in super.

Which issue(s) this PR fixes : Fixes #

/kind feature

wondywang commented 1 year ago

@christopherhein @Fei-Guo

PTAL, thanks.

Fei-Guo commented 1 year ago

LGTM.

I will let @christopherhein to approve.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, wondywang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment