kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

NestedControlPlane & NestedCluster Controllers #43

Closed christopherhein closed 3 years ago

christopherhein commented 3 years ago

This PR adds in the NCP and NC controllers for orchestrating the control plane creation by setting up all PKI and creating necessary components.

TODO:

Related

closes #33 closes #32

christopherhein commented 3 years ago

/assign @charleszheng44 @Fei-Guo

Fei-Guo commented 3 years ago

LGTM. I will leave to @charleszheng44 to give another pass.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charleszheng44, christopherhein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/master/OWNERS)~~ [charleszheng44,christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
charleszheng44 commented 3 years ago

/lgtm