search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

⚠️ Move controlplane.cluster.x-k8s.io components to controlplane/ #45

Closed christopherhein closed 3 years ago

christopherhein commented 3 years ago

When we look at other CAPI implementations instead of using multi-group controllers they typically are deployed as independent controllers, they're even built this way, for example see kcp in controlplane/kubeadm/ in https://github.com/kubernetes-sigs/cluster-ap while the main types NestedCluster in our world live usually at the top level, eg https://github.com/kubernetes-sigs/cluster-api-provider-aws you can even see the eks controlplane is built in controlplane/eks/ https://github.com/kubernetes-sigs/cluster-api-provider-aws/tree/main/controlplane/eks.

We should adjust to having the 4 controlplane group's resources in controlplane/nested/ and have only the top level NestedCluster at / this will also make it easier to co-operate if we eventually transition to kcp (eg #44)

christopherhein commented 3 years ago

/milestone v0.1.x

christopherhein commented 3 years ago

/kind cleanup

christopherhein commented 3 years ago

/assign