Closed christopherhein closed 3 years ago
We should have our PRs being tested for us with Prow on PR submission so we can have better assurance of the code.
Our pre-submit should run make generate lint test. This should be called from a script like other Cluster API providers so that we can periodically change what it does without needing to update the test-infra repo. EG https://github.com/kubernetes-sigs/cluster-api-provider-aws/tree/main/scripts
make generate lint test
test-infra
/assign
We should have our PRs being tested for us with Prow on PR submission so we can have better assurance of the code.
Links
Our pre-submit should run
make generate lint test
. This should be called from a script like other Cluster API providers so that we can periodically change what it does without needing to update thetest-infra
repo. EG https://github.com/kubernetes-sigs/cluster-api-provider-aws/tree/main/scripts