⚠️ Change default branch to "main"

christopherhein commented 3 years ago

Instructions here https://www.kubernetes.dev/resources/rename/

Anytime

[x] If a presubmit or postsubmit prowjob triggers on the master branch (branches field of the prowjob), add the main branch to the list (see kubernetes/test-infra#20665 for an example).
[x] If the milestone_applier prow config references the master branch, add the main branch to the config (see kubernetes/test-infra#20675 for an example).
[x] If the branch_protection prow config references the master branch, add the main branch to the config.

Just before rename

[x] periodic prowjobs, or any prowjob that mentions the master
[x] If a prowjob mentions master in its name, rename the job to not include the branch name
[x] If a prowjob calls scripts or code in your repo that explicitly reference master

Finalizing

[x] Set remote head to track main
[x] Rename the default branch from master to main
[x] #66 fix apidiff branch name

Post-rename
[x] If a prowjob still references the master branch in the branches field, remove the master branch
- [x] https://github.com/kubernetes/test-infra/pull/22309
[x] ~If the milestone_applier prow config references the master branch, remove it from the config.~
[x] Send out comms

/kind cleanup /wg naming

k8s-ci-robot commented 3 years ago

@christopherhein: The provided milestone is not valid for this repository. Milestones in this repository: [next, v0.1.0, v0.1.x]

Use /milestone clear to clear the milestone.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-nested/issues/47): >Instructions here https://www.kubernetes.dev/resources/rename/ > >/kind cleanup >/wg naming >/milestone Next Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

christopherhein commented 3 years ago

/milestone v0.1.x

christopherhein commented 3 years ago

/assign @kubernetes/owners

As per - https://www.kubernetes.dev/resources/rename/#approval

spiffxp commented 3 years ago

So I see you checked a bunch of boxes but what exactly did you do? Do you have links to PRs or descriptions of why you're good to go?

christopherhein commented 3 years ago

@spiffxp we didn't have a lot of work since this is a relatively new repo, we only have one Prow job which was added recently with this issue in mind - https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api-provider-nested/cluster-api-provider-nested-presubmits.yaml#L10 and in those the scripts that are called act solely on the branch that was pulled. Both branch_protection and milestone_applier haven't been configured yet.

Additionally, We discussed this on today's CAPN Office hours as well - https://www.youtube.com/watch?v=-bbUzYKHFls&t=5s to pre-emptively get folks ready for when the change goes into effect.

spiffxp commented 3 years ago

You'll want to take care of https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/fefd2138922b0d24a7ebe8c569cef0bc2f42e242/Makefile#L147

But +1 as a github admin to go ahead

christopherhein commented 3 years ago

Good catch, thank you, I'll get that fixed up after the branch change.

christopherhein commented 3 years ago

Branch has been changed in the Githuh UI and not is tracking the main branch. https://github.com/kubernetes-sigs/cluster-api-provider-nested/tree/main

christopherhein commented 3 years ago

/close Thanks folks for all your help on this! 🎉
https://groups.google.com/g/kubernetes-sig-cluster-lifecycle/c/Woe731ONmBc

k8s-ci-robot commented 3 years ago

@christopherhein: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-nested/issues/47#issuecomment-846146702): >/close >Thanks folks for all your help on this! 🎉 >https://groups.google.com/g/kubernetes-sig-cluster-lifecycle/c/Woe731ONmBc Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

kubernetes-retired / cluster-api-provider-nested