search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

🌱 Reenabling more Lint tasks #49

Closed christopherhein closed 3 years ago

christopherhein commented 3 years ago

This PR should be held open until after https://github.com/kubernetes/test-infra/pull/22090 is merged so we can test that the presubmit hooks is working.

Related

closes #46

Signed-off-by: Chris Hein me@chrishein.com

christopherhein commented 3 years ago

/retest

christopherhein commented 3 years ago

/assign @Fei-Guo

Fei-Guo commented 3 years ago

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, Fei-Guo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/master/OWNERS)~~ [Fei-Guo,christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment