🌱 Add Release Prow Jobs

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters

Apache License 2.0

301 stars 67 forks source link

🌱 Add Release Prow Jobs #60

Closed christopherhein closed 3 years ago

christopherhein commented 3 years ago

Prior to the first version being released we need to add to the scripts/ dir the proper release scripts as well as setup Prow release jobs. For now we should have just CAPN covered, we'll eventually create separate jobs for virtualcluster releases.

TODOS:

[x] https://github.com/kubernetes/k8s.io/pull/2123/ Request GCP Project
[x] Setup Makefile
[x] Add Image build prow jobs

christopherhein commented 3 years ago

/milestone v0.1.x

christopherhein commented 3 years ago

@vincepri do you have any examples or guides in how other Cluster API Providers handle releases and what we need to setup? I believe we already have a lot of the tooling in-place but just need to wire it all together.

vincepri commented 3 years ago

For releases, we usually have a bunch of things setup:

The Makefile targets to get the images built: https://github.com/kubernetes-sigs/cluster-api/blob/master/Makefile#L469-L577
- There is a lot in here, you can probably remove a bunch of things given that CAPI builds releases multiple components as part of the release process.
A cloudbuild job: https://github.com/kubernetes-sigs/cluster-api/blob/master/cloudbuild.yaml

The above was built on top of what the default Makefile was at the time we built the CAPI project with kubebuilder. If you need some sync time happy to jump on Zoom and chat about the steps.

There are also some bits to configure in test-infra, and in the k/k8s.io repositories.

christopherhein commented 3 years ago

@vincepri for the Cloudbuild job, do we need to make our own gcloud project or is this picked up from prow? I guess maybe that is setup here - https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/k8s-staging-cluster-api.yaml ?

christopherhein commented 3 years ago

/assign

vincepri commented 3 years ago

@christopherhein Yes the setup is there, you'll also need to request a GCP project like the one in here https://github.com/kubernetes/k8s.io/tree/main/audit/projects/k8s-staging-cluster-api

christopherhein commented 3 years ago

Awesome, thanks that part is what I was missing!

christopherhein commented 3 years ago

I forgot I cleaned up the Makefile in the last PR adding Prow presubmits - https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/Makefile#L300-L351

christopherhein commented 3 years ago

/close

k8s-ci-robot commented 3 years ago

@christopherhein: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-nested/issues/60#issuecomment-858149085): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

christopherhein commented 3 years ago

This was completed across many PRs and testing.