search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

✨ Adding virtualcluster to prow #68

Closed christopherhein closed 3 years ago

christopherhein commented 3 years ago

This adds virtualcluster/ subdirectory to the prow presubmit, this will allow us to validate if changes in PRs break VC or CAPN.

closes #64

Signed-off-by: Chris Hein me@chrishein.com

/milestone v0.1.x /kind cleanup

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
christopherhein commented 3 years ago

/cc @Fei-Guo @weiling61 @charleszheng44

Fei-Guo commented 3 years ago

/lgtm