search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

Proposal for ControlPlane Custom Resources #7

Closed christopherhein closed 3 years ago

christopherhein commented 4 years ago

This should cover how the all the Nested* types work together.

christopherhein commented 4 years ago

/assign @charleszheng44

christopherhein commented 3 years ago

/kind design

christopherhein commented 3 years ago

/priority important-soon

vincepri commented 3 years ago

One little suggestion, for diagrams I'd suggest using PlantUML and reuse the build infrastructure we've got upstream https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/Makefile#L28

By running make diagrams, the directive generates all PlantUML diagrams under docs/** and places them right next to the PlantUML file, vscode also has a nice extension for it :)

christopherhein commented 3 years ago

great idea @vincepri

christopherhein commented 3 years ago

/close

k8s-ci-robot commented 3 years ago

@christopherhein: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-nested/issues/7#issuecomment-736733512): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.