search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

Setting kind name as CAPN #72

Closed gyliu513 closed 3 years ago

gyliu513 commented 3 years ago

Sometimes people want to run multiple kind clusters to have different test purpose, it is better to add a name for the kind cluster for capn as well.

Fei-Guo commented 3 years ago

Thanks for the fix.

/lgtm

christopherhein commented 3 years ago

@gyliu513 looks like you need to rebase. I'm wondering if this is necessary? Since if a person is already running a kind they should know this and would have the sense to add the --name flag. 🤔

Either way we should probably add a Cleanup section to this doc that does kind delete cluster --name capn.

christopherhein commented 3 years ago

Thanks for adding this! 🎉

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, gyliu513

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment