search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

Fix golang-ci lint configuration exclude configuration #80

Closed sbueringer closed 3 years ago

sbueringer commented 3 years ago

The exclude configuration Using the variable on range scope (tc)|(rt)|(tt)|(test)|(testcase)|(testCase) in function literal in .golang.ci.yml matches too many findings.

Every finding which contains "rt", "tt", "test", .. is excluded.

For more context:

christopherhein commented 3 years ago

/good-first-issue /help /kind cleanup

k8s-ci-robot commented 3 years ago

@christopherhein: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-nested/issues/80): >/good-first-issue >/help >/kind cleanup Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
christopherhein commented 3 years ago

thanks @sbueringer for opening this.