kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

🌱 VN Agent Healthz Checks #87

Closed christopherhein closed 3 years ago

christopherhein commented 3 years ago

This add the ability to use vn-agent with a kubeconfig specified, which works for the Deployment style vs the DaemonSet mechanism as well this added a /healthz endpoint for better checking of it's availability.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
christopherhein commented 3 years ago

/kind feature

christopherhein commented 3 years ago

/assign @charleszheng44 @Fei-Guo

Fei-Guo commented 3 years ago

The envTest fails. Looking at the log

2021-06-03T18:32:39.544Z INFO controllers.VirtualCluster.Native service already exist {"service": "apiserver-svc"} STEP: Faking apiserver STS Status Updates STEP: Creating Control Plane controller-manager StatefulSet 2021-06-03T18:32:45.550Z INFO controllers.VirtualCluster.Native creating secret {"name": "root-ca", "namespace": "default-137bf3-virtualcluster-samplevxjfk"}

There is a 6 seconds gap between service log and creating secret log which looks weird. I only see one Get call in between from code which can be slow.

We probably need to increase the timeout in envTest.

charleszheng44 commented 3 years ago

/lgtm