Closed christopherhein closed 3 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: christopherhein
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/kind feature
/assign @charleszheng44 @Fei-Guo
The envTest fails. Looking at the log
2021-06-03T18:32:39.544Z INFO controllers.VirtualCluster.Native service already exist {"service": "apiserver-svc"} STEP: Faking apiserver STS Status Updates STEP: Creating Control Plane controller-manager StatefulSet 2021-06-03T18:32:45.550Z INFO controllers.VirtualCluster.Native creating secret {"name": "root-ca", "namespace": "default-137bf3-virtualcluster-samplevxjfk"}
There is a 6 seconds gap between service log and creating secret log which looks weird. I only see one Get call in between from code which can be slow.
We probably need to increase the timeout in envTest.
/lgtm
This add the ability to use vn-agent with a
kubeconfig
specified, which works for the Deployment style vs the DaemonSet mechanism as well this added a/healthz
endpoint for better checking of it's availability.