search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

🌱 Upgrade Golang CI & Fix Lint #90

Closed christopherhein closed 3 years ago

christopherhein commented 3 years ago

This upgrades golangci and cleans up a bunch of linting issues that came up from previously having false positives in the test suite.

Related

closes #80

christopherhein commented 3 years ago

/kind cleanup /milestone v0.1.x

christopherhein commented 3 years ago

/assign @Fei-Guo

christopherhein commented 3 years ago

/assign @charleszheng44

charleszheng44 commented 3 years ago

Wow, there are a lot of minor grammar issues. The code looks much better.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charleszheng44, christopherhein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [charleszheng44,christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
charleszheng44 commented 3 years ago

/lgtm