search

kubernetes-retired / cluster-registry

[EOL] Cluster Registry API
https://kubernetes.github.io/cluster-registry/
Apache License 2.0
238 stars 94 forks source link

Migrate the cluster registry to use a CRD #225

Closed perotinus closed 6 years ago

perotinus commented 6 years ago

This PR has many commits. I think it will be easier to review commit-by-commit rather than reviewing the entire PR at once.

Follow-up items being tracked in #229.

/sig multicluster

cc @font @pmorie @madhusudancs

perotinus commented 6 years ago

/assign @pmorie @madhusudancs @font

perotinus commented 6 years ago

The test failures are expected: bazel isn't used anymore in the repo, and the code generation does not have a verification script working yet.

perotinus commented 6 years ago

@pmorie @madhusudancs @font Bump.

If it helps, I think the most important commits to review are:

followed by:

The rest of the commits are either removing code; adding generated code; fixing code to use new generated code paths; and updating the Go verification script.

pmorie commented 6 years ago

@perotinus looks like a great start. Do you expect the CI jobs to fail?

perotinus commented 6 years ago

@pmorie Yes, I do: I've removed all the bazel infrastructure, as well as the code generation scripts. I think I will submit a PR to remove the bazel jobs when this PR is approved, just before merging; and I can add a dummy script that makes the pull-cluster-registry-verify-gensrc pass, before later adding support for verifying the kubebuilder generation.

pmorie commented 6 years ago

@perotinus that sounds like a sensible approach.

k8s-ci-robot commented 6 years ago

@perotinus: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cluster-registry-verify-bazel 424c105c6c9de13ad2fa2f4a127470a8467b745b link /test pull-cluster-registry-verify-bazel
pull-cluster-registry-bazel 424c105c6c9de13ad2fa2f4a127470a8467b745b link /test pull-cluster-registry-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
perotinus commented 6 years ago

/retest

perotinus commented 6 years ago

/retest

perotinus commented 6 years ago

@pmorie Any objections to this going in?

font commented 6 years ago

The only other thing we need to add to the list of follow-ups is validation for this CRD.

/lgtm

font commented 6 years ago

Thanks! /lgtm

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: font, perotinus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cluster-registry/blob/master/OWNERS)~~ [font,perotinus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment