Follow-up tasks for CRD conversion

kubernetes-retired / cluster-registry

[EOL] Cluster Registry API

https://kubernetes.github.io/cluster-registry/

Apache License 2.0

238 stars 88 forks source link

Follow-up tasks for CRD conversion #229

Closed perotinus closed 6 years ago

perotinus commented 6 years ago

/sig multicluster

Follow-up tasks from #225, migrated here for easier tracking

[x] switch to a namespaced object (#228)
[x] remove the unnecessary test jobs
[x] figure out what needs to be done with LICENSES
[ ] create a release process for the CRD
[ ] figure out if/how to write a test to verify that the kubebuilder generated code is up-to-date
[ ] run the integration tests in /test/... before each PR
[x] close bugs made irrelevant by this PR
[ ] validation
[x] look at removing pkg/inject if it's not necessary.
[x] fix issue with cluster CRD additionalPermissions field (#231)

fejta-bot commented 6 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 6 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 6 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 6 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes/cluster-registry/issues/229#issuecomment-434115897): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.