Two updates to the cluster API: adding a condition to the status, and modifying the AuthInfo

perotinus commented 6 years ago

/sig multicluster

This PR proposes two changes to the cluster registry API:

adding a conditions object to the status, and defining one condition, OK
removing the list of providers with maps of data from AuthInfo in favor of two object references, one for controller authentication and one for user authentication.

I think the first change is valuable before we move the API to beta, and the condition I've defined is relevant to any environment that's running a cluster registry. The second change doesn't change the expressiveness of the API in any way, but it provides a more clear split between how controllers and users interact with the cluster object, and an easier-to-work with interface for allowing users to use the cluster registry to get access to credentials. It also works around a minor issue with CRD validation spec generation.

With these changes I would feel comfortable moving the API to beta.

/cc @font @pmorie @madhusudancs

madhusudancs commented 6 years ago

/lgtm

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: madhusudancs, perotinus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cluster-registry/blob/master/OWNERS)~~ [madhusudancs,perotinus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubernetes-retired / cluster-registry

Two updates to the cluster API: adding a condition to the status, and modifying the AuthInfo #234