search

kubernetes-retired / cluster-registry

[EOL] Cluster Registry API
https://kubernetes.github.io/cluster-registry/
Apache License 2.0
238 stars 94 forks source link

Upgrade kubebuilder to 0.1.12. #244

Closed gyliu513 closed 6 years ago

gyliu513 commented 6 years ago

Fixed https://github.com/kubernetes/cluster-registry/issues/243

/cc @font @madhusudancs @perotinus @pmorie

/sig multicluster

perotinus commented 6 years ago

@gyliu513 Apologies for letting this sit for so long! This looks reasonable to me overall. Was there a different version of the docs dependencies pulled in by kubebuilder? I noticed a significant amount of churn there which I didn't look at in detail.

gyliu513 commented 6 years ago

@perotinus I will check more for this, but for now, the 0.1.12 has just released, so I'd prefer that we upgrade to 0.1.12 directly in this PR, what do you think?

gyliu513 commented 6 years ago

/retest

perotinus commented 6 years ago

@gyliu513 Thank you! Upgrading to 0.1.12 seems like the right approach to me as well.

perotinus commented 6 years ago

Can you adjust the comment message on the first commit, https://github.com/kubernetes/cluster-registry/pull/244/commits/ff31d318b867176bbd211e3e07148e522b204f58? Other than that, LGTM.

gyliu513 commented 6 years ago

@perotinus the first pr is updating to 0.11, and the second pr is updating to 0.12 at https://github.com/kubernetes/cluster-registry/pull/244/commits/c3a4a4ae352d8d678f06b22a3c2ecf5961f50024

Can we keep the commit message as it is as this can reflect the work process of this PR?

perotinus commented 6 years ago

@gyliu513 Sure, that seems fine to me. In that case, can you update the commit message of https://github.com/kubernetes/cluster-registry/commit/c3a4a4ae352d8d678f06b22a3c2ecf5961f50024 so that it specifies that it's updating to 0.12?

gyliu513 commented 6 years ago

@perotinus the commit message does include 0.1.12 https://github.com/kubernetes/cluster-registry/commit/c3a4a4ae352d8d678f06b22a3c2ecf5961f50024

image

perotinus commented 6 years ago

/lgtm /approve

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, perotinus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cluster-registry/blob/master/OWNERS)~~ [perotinus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
perotinus commented 6 years ago

@gyliu513 Ah, OK, sorry about that.