kubernetes-retired / cluster-registry

[EOL] Cluster Registry API
https://kubernetes.github.io/cluster-registry/
Apache License 2.0
238 stars 94 forks source link

fix typo #248

Closed max8899 closed 6 years ago

max8899 commented 6 years ago

depedencies -> dependencies

/sig multicluster

k8s-ci-robot commented 6 years ago

Hi @max8899. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: max8899 To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: perotinus

Assign the PR to them by writing /assign @perotinus in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/cluster-registry/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
perotinus commented 6 years ago

@max8899 Thanks for this PR! However, I believe that the typo that you're fixing is in an upstream project: https://github.com/pwittrock/brodocs/blob/master/README.md

It would probably be better to fix it there, and catch the change in the next update of this repo's docs.

idealhack commented 6 years ago

Closing in favor of https://github.com/Birdrock/brodocs/pull/6

/close