search

kubernetes-retired / cluster-registry

[EOL] Cluster Registry API
https://kubernetes.github.io/cluster-registry/
Apache License 2.0
238 stars 94 forks source link

fix some typo #249

Closed max8899 closed 5 years ago

max8899 commented 6 years ago

consistenly -> consistently neccessary ->necessary

/sig multicluster

perotinus commented 6 years ago

@max8899 Thanks for the PR! I believe these issues need to be fixed upstream (maybe https://github.com/flesler/jquery.scrollTo/blob/master/CHANGELOG.md) and reflected back here.

gyliu513 commented 6 years ago

/ok-to-test

gyliu513 commented 6 years ago

ah, sorry @perotinus , just saw your comments, +1 to fix in upstream

/lgtm cancel

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: max8899 To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: pmorie

Assign the PR to them by writing /assign @pmorie in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/cluster-registry/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
perotinus commented 6 years ago

@gyliu513 No worries, thank you for reviewing!

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale