search

kubernetes-retired / cluster-registry

[EOL] Cluster Registry API
https://kubernetes.github.io/cluster-registry/
Apache License 2.0
238 stars 94 forks source link

Added status to cluster yaml template. #252

Closed gyliu513 closed 6 years ago

gyliu513 commented 6 years ago

/sig multicluster

/cc @perotinus

perotinus commented 6 years ago

@gyliu513 Thank you! Does this also need to be added to the example files, or do they work as-is?

gyliu513 commented 6 years ago

Thanks @perotinus , yes, we should also update the samples as you mentioned, new commits updated.

perotinus commented 6 years ago

/lgtm /approve

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, perotinus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cluster-registry/blob/master/OWNERS)~~ [perotinus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment