search

kubernetes-retired / cluster-registry

[EOL] Cluster Registry API
https://kubernetes.github.io/cluster-registry/
Apache License 2.0
238 stars 94 forks source link

Fix a missing 'omitempty' tag. #256

Closed perotinus closed 6 years ago

perotinus commented 6 years ago

The Cluster's Status field was missing the 'omitempty' tag, which caused the generation machinery to mark it as required. It should be optional.

/cc @madhusudancs @font @pmorie /sig multicluster

G-Harmon commented 6 years ago

/lgtm

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: G-Harmon, perotinus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cluster-registry/blob/master/OWNERS)~~ [perotinus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment