search

kubernetes-retired / cluster-registry

[EOL] Cluster Registry API
https://kubernetes.github.io/cluster-registry/
Apache License 2.0
238 stars 94 forks source link

Upgrade kubebuilder to 1.0.3. #258

Closed gyliu513 closed 5 years ago

gyliu513 commented 5 years ago

/sig multicluster

/cc @font @madhusudancs @perotinus @pmorie

perotinus commented 5 years ago

/lgtm

perotinus commented 5 years ago

/ok-to-test

perotinus commented 5 years ago

/retest

font commented 5 years ago

@gyliu513 can you separate generated code from non-generated code into distinct commits?

gyliu513 commented 5 years ago

@font all of the code are generated automatically via kubebuilder 1.0.3 by following steps at https://github.com/kubernetes/cluster-registry/blob/master/docs/development.md#updating-generated-codedocs , and I just update this PR by separating the fix for gofmt which was not automatically generated by kubebuilder, hope it is OK.

gyliu513 commented 5 years ago

/test pull-cluster-registry-verify-gosrc

font commented 5 years ago

@gyliu513 Can you check the failed job?

gyliu513 commented 5 years ago

@font This seems share same root cause as https://github.com/kubernetes/cluster-registry/pull/259#issuecomment-421374095 , there is no vendor, but I think vendor should be generated by CI?

gyliu513 commented 5 years ago

/retest

gyliu513 commented 5 years ago

/retest

gyliu513 commented 5 years ago

/retest

gyliu513 commented 5 years ago

Ping @font for a /lgtm label

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: font, gyliu513, perotinus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cluster-registry/blob/master/OWNERS)~~ [font,perotinus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment