search

kubernetes-retired / cluster-registry

[EOL] Cluster Registry API
https://kubernetes.github.io/cluster-registry/
Apache License 2.0
238 stars 94 forks source link

Document crd-install annotation for cluster registry crd. #259

Closed gyliu513 closed 5 years ago

gyliu513 commented 5 years ago

/sig multicluster

/cc @font @madhusudancs @perotinus @pmorie

perotinus commented 5 years ago

/lgtm /approve

perotinus commented 5 years ago

/lgtm /approve

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, perotinus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cluster-registry/blob/master/OWNERS)~~ [perotinus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
BenTheElder commented 5 years ago

/retest

perotinus commented 5 years ago

/retest

perotinus commented 5 years ago

@gyliu513 It looks like the test actually failed this time. Can you investigate?

BenTheElder commented 5 years ago

It looks like you're failing because you don't have anything in vendor/ for dependencies but these scripts are trying to vet / lint ?

gyliu513 commented 5 years ago

Thakns @BenTheElder , right, the reason is because vendor was not committed in this repo.

@perotinus , I think the CI should generate the vendor first, but seems the CI is not, do you know why?

gyliu513 commented 5 years ago

/retest

gyliu513 commented 5 years ago

/retest

gyliu513 commented 5 years ago

/retest