search

kubernetes-retired / cluster-registry

[EOL] Cluster Registry API
https://kubernetes.github.io/cluster-registry/
Apache License 2.0
238 stars 94 forks source link

Fix typos in the files #265

Closed mooncak closed 5 years ago

mooncak commented 6 years ago

Signed-off-by: mooncake xcoder@tenxcloud.com

/sig multicluster

Fix typos in below files:

  1. docs/reference/build/README.md
  2. docs/reference/build/scroll.js
  3. hack/imports.go
mooncak commented 6 years ago

/assign @perotinus

mooncak commented 6 years ago

@perotinus @madhusudancs @pmorie could you pls help review and approve? tks

perotinus commented 6 years ago

Thank you for the PR!

/ok-to-test

mooncak commented 5 years ago

@perotinus can you help approve this PR? tks.

perotinus commented 5 years ago

@mooncak I would be happy to, assuming that you've made changes to docs/reference/build/README.md and docs/reference/build/scroll.js at their sources. Do you have pointers to PRs that fix these issues in the source? If not, can you please revert these files so that future updates don't undo these changes and create noise?

mooncak commented 5 years ago

@perotinus I have made changes to docs/reference/build/README.md and docs/reference/build/scroll.js at their sources. the PR are: https://github.com/Birdrock/brodocs/pull/7 https://github.com/Birdrock/brodocs/pull/8 but it may need some time for @Birdrock to merge.

perotinus commented 5 years ago

/lgtm

One small tweak.

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mooncak, perotinus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cluster-registry/blob/master/OWNERS)~~ [perotinus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment