kubernetes-retired / contrib

[EOL] This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.
Apache License 2.0
2.46k stars 1.68k forks source link

Convert registry to k8s.gcr.io #2814

Closed thockin closed 6 years ago

thockin commented 6 years ago

This PR was auto-generated. Please apply human expertise to review for correctness.

Followup to https://github.com/kubernetes/kubernetes/pull/54174 and https://github.com/kubernetes/kubernetes/pull/57824

xref https://github.com/kubernetes/release/issues/281

k8s-reviewable commented 6 years ago

This change is Reviewable

bowei commented 6 years ago

lgtm

thockin commented 6 years ago

@dekkagaijin I, too, am experiencing issues. This all worked at some point.

thockin@freakshow2 kubernetes gcr-vanity /$ docker images | egrep '(pause|thtest)'

thockin@freakshow2 kubernetes gcr-vanity /$ docker pull gcr.io/google_containers/pause
Using default tag: latest
latest: Pulling from google_containers/pause
a3ed95caeb02: Pull complete 
4964c72cd024: Pull complete 
Digest: sha256:a78c2d6208eff9b672de43f880093100050983047b7b0afe0217d3656e1b0d5f
Status: Downloaded newer image for gcr.io/google_containers/pause:latest

thockin@freakshow2 kubernetes gcr-vanity /$ docker images | egrep '(pause|thtest)'
gcr.io/google_containers/pause                   latest                        350b164e7ae1        3 years ago         239.8 kB

thockin@freakshow2 kubernetes gcr-vanity /$ docker tag gcr.io/google_containers/pause k8s.gcr.io/thtest:thtest 

thockin@freakshow2 kubernetes gcr-vanity /$ docker images | egrep '(pause|thtest)'
gcr.io/google_containers/pause                   latest                        350b164e7ae1        3 years ago         239.8 kB
k8s.gcr.io/thtest                                thtest                        350b164e7ae1        3 years ago         239.8 kB

thockin@freakshow2 kubernetes gcr-vanity /$ gcloud docker -- push k8s.gcr.io/thtest:thtest
The push refers to a repository [k8s.gcr.io/thtest]
5f70bf18a086: Layer already exists 
e16a89738269: Pushing [==================================================>] 241.7 kB
unexpected EOF
dekkagaijin commented 6 years ago

2 possible solutions:

thockin commented 6 years ago

Confirmed, update worked for me

On Thu, Dec 28, 2017 at 11:18 AM, Jake Sanders notifications@github.com wrote:

2 possible solutions: updated gcloud to >= 183.0.0 (where k8s.gcr.io was added as a default domain) or use gcloud docker -s k8s.gcr.io -- push ...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kubernetes/contrib/pull/2814#issuecomment-354342375, or mute the thread https://github.com/notifications/unsubscribe-auth/AFVgVHCaf2uNGvliyE1B62fMImRIUGMUks5tE-migaJpZM4RLSS9 .

mikedanese commented 6 years ago

/approve

k8s-github-robot commented 6 years ago

@thockin PR needs rebase

mikedanese commented 6 years ago

/approve

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mikedanese, MrHohn, porridge, thockin We suggest the following additional approver: eparis

Assign the PR to them by writing /assign @eparis in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - **[OWNERS](https://github.com/kubernetes/contrib/blob/master/OWNERS)** You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
k8s-github-robot commented 6 years ago

/lgtm cancel //PR changed after LGTM, removing LGTM. @MrHohn @caesarxuchao @eparis @porridge @thockin

k8s-github-robot commented 6 years ago

@thockin PR needs rebase