search

kubernetes-retired / contrib

[EOL] This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.
Apache License 2.0
2.46k stars 1.68k forks source link

scratch-debugger: fix mounted path for socket #2821

Closed ahmetb closed 6 years ago

ahmetb commented 6 years ago

The manifest file for the debug container makes the host's docker socket available on /mnt/rootfs/var/run/docker.sock, but the script still tries to use non-existing /run/docker.sock on the container's fs.

/cc @tallclair

k8s-reviewable commented 6 years ago

This change is Reviewable

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: We suggest the following additional approver: foxish

Assign the PR to them by writing /assign @foxish in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - **[OWNERS](https://github.com/kubernetes/contrib/blob/master/OWNERS)** You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
ahmetb commented 6 years ago

Superseded by #2824.