staging-container: stop relying on host docker CLI

kubernetes-retired / contrib

[EOL] This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.

Apache License 2.0

2.46k stars 1.68k forks source link

staging-container: stop relying on host docker CLI #2824

Closed ahmetb closed 6 years ago

ahmetb commented 6 years ago

This change supersedes #2320, #2321 and #2322:

Stop relying on host docker: (1) it might be dynamically compiled and therefore might not work on busybox (2) it might not be at /usr/bin/docker.
Removed mounting of entire host root filesystem to /mnt/rootfs as it's not needed anymore. Mounting only the /var/run/docker.sock now.
Fixed a stderr redirection bug that caused log line to be saved as a file.

/assign @tallclair

k8s-reviewable commented 6 years ago

This change is

ahmetb commented 6 years ago

@tallclair thanks for reviewing. I moved docker CLI out of /tmp. It looks kinda uglier now (/docker-cli/docker/docker) but if you have any ideas to make it better I'm open to it.

foxish commented 6 years ago

If this is maintained, please consider adding an OWNERS file to the directory. @timstclair @ahmetb Also, can we find a long term home for this besides contrib?

ahmetb commented 6 years ago

I don't think it deserves it's own repo under kubernetes or kubernetes-incubator, either. It's just a hack script, the way I see it. I'm open to being an OWNERS of this.

We have the same problem in k/examples repo, and for that, we encourage people to host these stuff on their personal accounts. Do you have a better suggestion @foxish?

ahmetb commented 6 years ago

@tallclair ping for approval

ahmetb commented 6 years ago

/assign @foxish

foxish commented 6 years ago

/approve

Based on Tim's lgtm.

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, foxish, tallclair

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - ~~[OWNERS](https://github.com/kubernetes/contrib/blob/master/OWNERS)~~ [foxish] You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment