search

kubernetes-retired / contrib

[EOL] This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.
Apache License 2.0
2.46k stars 1.68k forks source link

Fetch list of jobs from prow config. #2825

Closed porridge closed 6 years ago

porridge commented 6 years ago

This is a step towards solving https://github.com/kubernetes/contrib/issues/2812 /hold Needs https://github.com/kubernetes/test-infra/pull/6220 to be merged first.

k8s-reviewable commented 6 years ago

This change is Reviewable

porridge commented 6 years ago

/cc @shyamjvs I plan to add config reloading later.

shyamjvs commented 6 years ago

/lgtm

Though the presubmit failed with:

# k8s.io/test-infra/prow/github
Godeps/_workspace/src/k8s.io/test-infra/prow/github/client.go:52: undefined: time.Until

Could you please fix it?

porridge commented 6 years ago

On Wed, Jan 10, 2018 at 7:26 PM, Shyam JVS notifications@github.com wrote:

Though the presubmit failed with:

k8s.io/test-infra/prow/github

Godeps/_workspace/src/k8s.io/test-infra/prow/github/client.go:52 http://k8s.io/test-infra/prow/githubGodeps/_workspace/src/k8s.io/test-infra/prow/github/client.go:52: undefined: time.Until

Could you fix it?

I think this means we need to change the golang version in the travis config, but I don't know how to do it. Asked on slack, got no replies so far.

shyamjvs commented 6 years ago

There should be a travis.yaml (I guess it's hidden) file at the root of this repo. You need to change it there.

shyamjvs commented 6 years ago

Here specifically - https://github.com/kubernetes/contrib/blob/master/.travis.yml#L10 But need to watch out for any other dependencies on the older go.

k8s-github-robot commented 6 years ago

/lgtm cancel //PR changed after LGTM, removing LGTM. @porridge @shyamjvs

porridge commented 6 years ago

Finally it works, PTAL @shyamjvs /approve

porridge commented 6 years ago

/assign @foxish

shyamjvs commented 6 years ago

/lgtm

On Thu, Jan 11, 2018, 9:33 AM Marcin Owsiany notifications@github.com wrote:

/assign @foxish https://github.com/foxish

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubernetes/contrib/pull/2825#issuecomment-356862563, or mute the thread https://github.com/notifications/unsubscribe-auth/AEIhk0ofiSEvTaBCkzJKuJQLBRCfQzGvks5tJcdJgaJpZM4RZlgR .

foxish commented 6 years ago

Contrib has turned into a collection of things falling into disuse, so, separating perfdash out might be a good thing to consider. It looks like it's actively used and maintained? We should try and find a new home for it then - maybe test-infra? @BenTheElder @krzyzacy @shyamjvs @porridge

cc @lavalamp

porridge commented 6 years ago

I agree, but do you think it should block this change?

foxish commented 6 years ago

/approve For the godeps changes. Not a blocker for this particular PR - but would be good to file an issue if there's an intent to move this out at some point in the future.

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxish, porridge, shyamjvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - ~~[OWNERS](https://github.com/kubernetes/contrib/blob/master/OWNERS)~~ [foxish] You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
porridge commented 6 years ago

The tags in prow config are checked in. /hold cancel