search

kubernetes-retired / contrib

[EOL] This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.
Apache License 2.0
2.46k stars 1.68k forks source link

Bump rescheduler version to v0.3.3 #2829

Closed sebbonnet closed 6 years ago

sebbonnet commented 6 years ago

To release changes made in #2712 and #2802

k8s-reviewable commented 6 years ago

This change is Reviewable

sebbonnet commented 6 years ago

/assign @piosz

piosz commented 6 years ago

@bsalamat could you plaese take a look?

bsalamat commented 6 years ago

/lgtm

bsalamat commented 6 years ago

@piosz You still need to approve. I don't have approval power in rescheduler directory.

piosz commented 6 years ago

/approve no-issue @bsalamat feel free to send a PR adding yourself to owners

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, piosz, sebbonnet

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - ~~[rescheduler/OWNERS](https://github.com/kubernetes/contrib/blob/master/rescheduler/OWNERS)~~ [piosz] You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
sebbonnet commented 6 years ago

@piosz @bsalamat thanks guys, but the v0.3.3 images are still not available in the repo. Does the publishing need to be done manually?

I was expecting images to be available like that:

docker pull gcr.io/google-containers/rescheduler-amd64:v0.3.3
docker pull gcr.io/google-containers/rescheduler:v0.3.3
bsalamat commented 6 years ago

I am not really familiar with the release process of rescheduler. @piosz do you know the answer?

sebbonnet commented 6 years ago

@bsalamat According to the Makefile make all all-push should publish all images

piosz commented 6 years ago

@bsalamat it's regular procedure of pushing various components to gcr.io.

bsalamat commented 6 years ago

I haven't been able to push the images using this command: gcloud docker -- push gcr.io/google-containers/rescheduler-amd64:v0.3.3

The error that I see is very vague: "Layer already exists". I wonder if I get this error due to lack of permission to push images to this repo.

sebbonnet commented 6 years ago

@bsalamat @piosz do you have any update on this, please?

jsravn commented 6 years ago

Ping @piosz

bsalamat commented 6 years ago

I cannot get those images published. I think I need some permission that I don't have. The error message is quite vague.