search

kubernetes-retired / contrib

[EOL] This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.
Apache License 2.0
2.46k stars 1.68k forks source link

[keepalived-vip] typo in IP address and virtual_ipaddress should same as virtual_server #2845

Closed Davidchinacloud closed 6 years ago

Davidchinacloud commented 6 years ago

virtual_ipaddress should same as virtual_server in /etc/keepalived/keepalived.conf and typo in IP address

Signed-off-by: LinWengang linwengang@chinacloud.com.cn

k8s-reviewable commented 6 years ago

This change is Reviewable

k8s-ci-robot commented 6 years ago

@Davidchinacloud: GitHub didn't allow me to assign the following users: PTAL.

Note that only kubernetes members and repo collaborators can be assigned.

In response to [this](https://github.com/kubernetes/contrib/pull/2845#issuecomment-364424464): >/assign @bowei PTAL Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Davidchinacloud commented 6 years ago

/assign @bowei PTAL

bowei commented 6 years ago

/lgtm /approve no-issue

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, Davidchinacloud

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[keepalived-vip/OWNERS](https://github.com/kubernetes/contrib/blob/master/keepalived-vip/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment