search

kubernetes-retired / contrib

[EOL] This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.
Apache License 2.0
2.46k stars 1.68k forks source link

[keepalived-vip] Propagate error when network interface name couldn't be detected #2851

Closed twz123 closed 6 years ago

twz123 commented 6 years ago

Be fail-fast in case when the network interface name auto detection fails. Otherwise, an empty interface name would be used, which in turn crashes keepalived with a segfault.

k8s-reviewable commented 6 years ago

This change is Reviewable

twz123 commented 6 years ago

/assign @bprashanth

twz123 commented 6 years ago

Ping... Someone here to review this?

bowei commented 6 years ago

/lgtm

bowei commented 6 years ago

/approve

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, twz123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[keepalived-vip/OWNERS](https://github.com/kubernetes/contrib/blob/master/keepalived-vip/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment