Closed lenalebt closed 6 years ago
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lenalebt To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: eparis
Assign the PR to them by writing /assign @eparis
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/assign eparis
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
I just realized that there have been formatting issues, which I resolved now. Anything I can do to get this merged :)?
We realized internally that this approach has some drawbacks; it sometimes does not recognize that the connected command terminates and then hangs. We have a solution (by my coworker) that solves these issues. We will create a new pull request for that.
@lenalebt did your alternative solution work out in the end? I just created #2944 since we ran into the same issue. If you found out more it'd be great to share it in the issue. Thanks! :)
Hi @andrenarchy - indeed, we have a more-or-less working solution. I am not 100% sure what exactly we changed, but I have added the source we used to compile our own version as a gist here: https://gist.github.com/lenalebt/9b2ed4abe659fe78a8f68b796d24fad7
Maybe you can use it to solve your issue, or post a new PR for this?
We had a problem with a hanging on-start script, and peer-finder waited for the script to terminate before writing it's output to stdout. This change directly writes the output to stdout as it happens, making it way easier to debug hanging startup scripts.