search

kubernetes-retired / contrib

[EOL] This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.
Apache License 2.0
2.46k stars 1.68k forks source link

fix some mistake #2871

Closed pzghost closed 6 years ago

pzghost commented 6 years ago

Fix some minor bugs.

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chenhonggc To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: bprashanth

Assign the PR to them by writing /assign @bprashanth in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[ingress/OWNERS](https://github.com/kubernetes/contrib/blob/master/ingress/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pzghost commented 6 years ago

/assign @bprashanth Please review, Thanks.

pzghost commented 6 years ago

@lavalamp Are there any problems with these commit？

k8s-ci-robot commented 6 years ago

@chenhonggc: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
fejta-bot commented 6 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale