search

kubernetes-retired / contrib

[EOL] This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.
Apache License 2.0
2.46k stars 1.68k forks source link

Moving perfdash to kubernetes/perf-tests #2885

Closed krzysied closed 6 years ago

shyamjvs commented 6 years ago

/hold (Until we have the PR adding perf-dash to the other repo merged)

wojtek-t commented 6 years ago

/hold (Until we have the PR adding perf-dash to the other repo merge

We already have. And it's merged.

/lgtm

wojtek-t commented 6 years ago

/unhold

shyamjvs commented 6 years ago

Sorry, I didn't keep track of that.

/approve no-issue

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzysied, shyamjvs, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[perfdash/OWNERS](https://github.com/kubernetes/contrib/blob/master/perfdash/OWNERS)~~ [shyamjvs] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
shyamjvs commented 6 years ago

/hold cancel

:)