search

kubernetes-retired / contrib

[EOL] This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.
Apache License 2.0
2.46k stars 1.68k forks source link

add option to use notfy scripts for keepalived #2912

Closed cornelius-keller closed 5 years ago

cornelius-keller commented 6 years ago

Hi, i modified keepalived-vip to add an option to use notify scripts. My change should be 100% backwards compatible to the previous behavior. It is enabled by mounting your notification script to the pod via a configmap, and then setting the env var KEEPALIVED_NOTIFY to the location where it is mounted. This will include a line like: notify /opt/your-notify-script.sh to the keepalived config.

I use this feature on cloud providers were you need a special api call to get an failover / floating IP routed to your machine.

I would like to have this merged so that I don't have to maintain a fork of keepalived-vip.

cornelius-keller commented 6 years ago

/assign @bprashanth

fejta-bot commented 6 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

voron commented 6 years ago

/remove-lifecycle stale

pierreozoux commented 5 years ago

@mikedanese or @bprashanth can you tell us how to move this forward? Or give us a name that could help us get this merged? Thanks!

steven-sheehy commented 5 years ago

@pierreozoux You might want to try the better maintained fork: https://github.com/aledbf/kube-keepalived-vip/

pierreozoux commented 5 years ago

@steven-sheehy I'd prefer an "official image". I'd like to avoid images maintained by third parties. If there is none, then okay, I'll have to maintain my fork, and build my own image. But if the official project delivers one, it would simplify the life of number of people including me.

cornelius-keller commented 5 years ago

@pierreozoux I totally agree that it is best to have this in the official image and not maintain a custom fork of it. @mikedanese @bprashanth would be nice if we can get at least a review. If there are changes required I am willing to put further effort into this but without having a clue what is missing this is difficult.

loxy commented 5 years ago

Will that ever be included?

muhlba91 commented 5 years ago

Is there any update on this PR? It would be great seeing this in the official image.

mikedanese commented 5 years ago

@kubernetes/sig-network-pr-reviews

md2k commented 5 years ago

Hi all, can this be reviewed and merged guys?

muhlba91 commented 5 years ago

fyi: as per @steven-sheehy's suggestion this has already been merged into https://github.com/aledbf/kube-keepalived-vip/ (PR: https://github.com/aledbf/kube-keepalived-vip/pull/79)

bowei commented 5 years ago

/lgtm /approve

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, cornelius-keller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[keepalived-vip/OWNERS](https://github.com/kubernetes/contrib/blob/master/keepalived-vip/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment