search

kubernetes-retired / contrib

[EOL] This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.
Apache License 2.0
2.46k stars 1.68k forks source link

Fix Rescheduler Makefile #2926

Closed yguo0905 closed 6 years ago

yguo0905 commented 6 years ago
  1. Allow overriding the REGISTRY from command line.
  2. Create a image without the ARCH in its name for backward compatibility.

/kind bug /assign @bsalamat

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, yguo0905

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[rescheduler/OWNERS](https://github.com/kubernetes/contrib/blob/master/rescheduler/OWNERS)~~ [bsalamat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment