Closed azrle closed 5 years ago
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: azrle To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: mrhohn
If they are not already assigned, you can assign the PR to them by writing /assign @mrhohn
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen
.
Mark the issue as fresh with /remove-lifecycle rotten
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close
@fejta-bot: Closed this PR.
Hi,
It is a PR to show the idea that it maybe good to introduce
timeout
option.The command itself sometimes hangs up for some reasons (e.g. network IO) and may run forever. It should be good to implement timeout in commands; however sometimes it is difficult to make changes to commands and cover every cases. Since timeout could be a general case, I would like to see it is implemented in
exec-healthz
.Note: this is a just workable code sample to show what I want to do. It could break tests, dependency and minimum required version of golang and packages. (Sorry that I am not familiar with policies and rules of this repo and cannot make a perfect PR; also saw this project is moving)