kubernetes-retired / contrib

[EOL] This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.
Apache License 2.0
2.46k stars 1.68k forks source link

fix link for ingress controller gce #2954

Closed dwdraju closed 5 years ago

k8s-ci-robot commented 5 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dwdraju commented 5 years ago

Signed the CLA.

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

venezia commented 5 years ago

/approve

venezia commented 5 years ago

/remove-lifecycle rotten

venezia commented 5 years ago

@dwdraju the system still does not think you've accepted the CLA. Your email address used in your git commit has to match the one used to sign the CLA. It may also need to be part of your public github profile, I actually am unsure on that part. Please verify this so and possibly correct so the bot can agree the commit complies with the CLA.

Thanks

dwdraju commented 5 years ago

Signed the CLA.

venezia commented 5 years ago

Thanks - sorry the delay - everything should automerge now!

venezia commented 5 years ago

/lgtm

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dwdraju, venezia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ingress/controllers/nginx/OWNERS](https://github.com/kubernetes/contrib/blob/master/ingress/controllers/nginx/OWNERS)~~ [venezia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment