search

kubernetes-retired / contrib

[EOL] This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.
Apache License 2.0
2.46k stars 1.68k forks source link

Update Zookeeper Docker Container to 3.4.13 and Ubuntu 18.04 #2965

Closed cablespaghetti closed 5 years ago

cablespaghetti commented 5 years ago

I noticed that the Zookeeper container in this repository was a few versions out of date and while I was there I upgraded it to Ubuntu 18.04 from 16.04. I am running this in my environment and it works properly.

Built image here for convenient testing: https://hub.docker.com/r/cablespaghetti/k8szk

k8s-ci-robot commented 5 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cablespaghetti To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: kow3ns

If they are not already assigned, you can assign the PR to them by writing /assign @kow3ns in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[statefulsets/zookeeper/OWNERS](https://github.com/kubernetes/contrib/blob/master/statefulsets/zookeeper/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cablespaghetti commented 5 years ago

/assign @kow3ns

I closed and re-opened to get Travis to re-run. I'm fairly sure the failure isn't to do with this change.

rlees85 commented 5 years ago

Worth updating openjdk to version 9 too as the latest version of Zookeeper supports this?

cablespaghetti commented 5 years ago

For some reason on my follower nodes I'm getting intermittent health/liveness check failures still (although less than with previous netcat version I was running). I'll investigate this.

rlees85 commented 5 years ago

Also (PLEASE correct me if i'm wrong) I don't think applications in kubernetes/contrib are maintained. There is another Zookeeper implementation here https://github.com/kow3ns/kubernetes-zookeeper but I have no idea if that is maintained either

cablespaghetti commented 5 years ago

You may be right. Although the current incubator helm chart for Zookeeper uses this image as a base. The other repo seems to be quite dead as well. :(

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten