Closed n-Arno closed 5 years ago
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: arnoSCC To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: mikedanese
If they are not already assigned, you can assign the PR to them by writing /assign @mikedanese
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Closing due to bad formatting of comments found by CI. Be back soon.
Following a rework of kube-keepalived-vip for a customer, we are contributing back the modifications.
1) Upgrade to Keepalived 2.0.10 ==> According to keepalived.org, versions 2.x are the go-to versions where bugfixes and improvements happens (no backport).
2) Custom interface handling ==> Ability to use an other interface rather than the internalIP/externalIP interface.
3) Vlan handling. ==> Ability to create vlan tagged interfaces complete with subnet mask and gateway route.
This is my first contribution back to an open-source projet, i hope i wrote here everything needed, in any case, 2 additional sections exist in the README (Custom interface and Advanced configuration) explaining what happens.