Closed n-Arno closed 5 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: arnoSCC To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: bprashanth
If they are not already assigned, you can assign the PR to them by writing /assign @bprashanth
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/assign @bprashanth
Ok, sorry i'm so bad at this. I'll manage to make hack/verify-all.sh works on my dev env and open a PR only when i'm sure the tests are ok.
Following a rework of kube-keepalived-vip for a customer, we are contributing back the modifications.
This is my first contribution back to an open-source projet, i hope i wrote here everything needed, in any case, 2 additional sections exist in the README (Custom interface and Advanced configuration) explaining what happens.