search

kubernetes-retired / contrib

[EOL] This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.
Apache License 2.0
2.46k stars 1.68k forks source link

Fixing non-success response handling #2995

Closed krzysied closed 5 years ago

krzysied commented 5 years ago

Returning error instead of nil when there is non-success response.

krzysied commented 5 years ago

/assign @gmarek @gmarek PTAL

gmarek commented 5 years ago

/lgtm /approve

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmarek, krzysied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test-utils/OWNERS](https://github.com/kubernetes/contrib/blob/master/test-utils/OWNERS)~~ [gmarek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment