search

kubernetes-retired / drivers

[EOL] Example CSI Drivers
Apache License 2.0
140 stars 92 forks source link

Image driver #133

Closed kfox1111 closed 5 years ago

kfox1111 commented 5 years ago

This is a prototype for a csi driver that uses a raw docker image as a volume source.

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kfox1111 To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: chakri-nelluri

If they are not already assigned, you can assign the PR to them by writing /assign @chakri-nelluri in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/drivers/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pohly commented 5 years ago

SIG-storage is trying to move each driver into its own repository, which will allow releasing them independently. I doubt that this driver (regardless of its merits) will be accepted here. Can't you just create your own repo and publish it from there?

kfox1111 commented 5 years ago

Yeah, that is issue https://github.com/kubernetes-csi/drivers/issues/81. its been stalled for a very long time.

We need to get csi pod inline support into k8s for 1.14 and if we have some drivers in tree to test against, it would be better. last I talked to @vladimirvivien he mentioned just putting the pr against drivers for now until someone can actually finish up the splitting up of the drivers repo.

I'm a bit afraid sig-storage is holding up work because it wants to do everything perfect from the get go, rather then getting stuff contributed and then keep working on making it better. For API's, its really important to get them as right as possible from the start. For drivers themselves, its not so critical. Please, lets keep making progress on them.

pohly commented 5 years ago

@kfox1111 I was just describing the current situation. I don't have any strong opinions on this. I'll let @saad-ali decide where this driver should go.

kfox1111 commented 5 years ago

yeah. not mad or anything. just stating that we've been struggling to contribute for a long time and keep getting stalled out. Just trying to figure out ways to make progress.

kfox1111 commented 5 years ago

Oh, and this is also related to https://github.com/kubernetes-csi/drivers/issues/85

kfox1111 commented 5 years ago

Its looking like the hostpath driver has finally been split out from drivers? Can we fork it for the image-driver? I'd be happy to rebase this top of that if someone can create it.

saad-ali commented 5 years ago

Let's move this in to it's own repo under kubernetes-csi.

Open an issue here https://github.com/kubernetes/org/issues

kfox1111 commented 5 years ago

Closing in favour of https://github.com/kubernetes-csi/csi-driver-image-populator/pull/1