search

kubernetes-retired / drivers

[EOL] Example CSI Drivers
Apache License 2.0
140 stars 92 forks source link

hostpath: Implement ValidateVolumeCapabilities #142

Closed darkowlzz closed 5 years ago

darkowlzz commented 5 years ago

This implements a basic version of ValidateVolumeCapabilities for hostpath driver and removes this from the skip tests list in the e2e tests.

Running the e2e tests locally always failed because it was skipped for travisCI environment only.

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: darkowlzz To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: sbezverk

If they are not already assigned, you can assign the PR to them by writing /assign @sbezverk in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/drivers/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pohly commented 5 years ago

This looks like a useful enhancement. However, the hostpath driver is about to be moved to a separate repo (see https://github.com/kubernetes-csi/csi-driver-host-path/pull/1), so the PR will have to be moved there once that PR is merged.

pohly commented 5 years ago

/hold

I'm holding this because we don't want to add any further changes here. It's still ready for review.

pohly commented 5 years ago

@darkowlzz Please move this PR over to the csi-driver-host-path repo. The code was merged into master of that repo.

darkowlzz commented 5 years ago

Moved to https://github.com/kubernetes-csi/csi-driver-host-path/pull/5.